tinqs/engine
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add compatibility fallback to textureLod when reading from RADIANCE

Browse Source 
This is needed due to the discontinuity in the seam of the octahedral coordinates

(cherry picked from commit 69a923e3402b45a44984703ffea826fa68ce0f53)
This commit is contained in:
Clay John
2026-02-10 16:00:30 -08:00
committed by Thaddeus Crews
parent 33b93719ec
commit 4d176d8b81
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
servers/rendering/shader_compiler.cpp
+11
View File
@@ -1171,6 +1171,7 @@ String ShaderCompiler::_dump_node_code(const SL::Node *p_node, int p_level, Gene
bool is_radiance_texture = false;
bool texture_func_no_uv = false;
bool texture_func_returns_data = false;
bool texture_func_simple = false;
if (onode->op == SL::OP_STRUCT) {
code += _mkid(vnode->name);
@@ -1187,6 +1188,7 @@ String ShaderCompiler::_dump_node_code(const SL::Node *p_node, int p_level, Gene
is_texture_func = texture_functions.has(vnode->name);
texture_func_no_uv = (vnode->name == "textureSize" || vnode->name == "textureQueryLevels");
texture_func_returns_data = texture_func_no_uv || vnode->name == "textureQueryLod";
texture_func_simple = vnode->name == "texture";
} else if (p_default_actions.renames.has(vnode->name)) {
code += p_default_actions.renames[vnode->name];
} else {
@@ -1324,6 +1326,10 @@ String ShaderCompiler::_dump_node_code(const SL::Node *p_node, int p_level, Gene
data_type_name = "multiviewSampler";
multiview_uv_needed = true;
} else if (is_radiance_texture) {
// We need to use an explicit level of detail to avoid mip mapping artifacts caused by the octahedral discontinuity.
if (texture_func_simple) {
code = code.replace("texture(", "textureLod(");
}
data_type_name = "sampler2D";
} else {
data_type_name = ShaderLanguage::get_datatype_name(onode->arguments[i]->get_datatype());
@@ -1361,6 +1367,11 @@ String ShaderCompiler::_dump_node_code(const SL::Node *p_node, int p_level, Gene
} else if (is_radiance_texture && !texture_func_no_uv && i == 2) {
node_code = "vec3_to_oct_with_border(" + node_code + ", params.border_size)";
// Need an explicit level of detail if one isn't provided by the user.
if (texture_func_simple && onode->arguments.size() == 3) {
node_code += ", 0.0";
}
code += node_code;
} else {
code += node_code;